Skip to content

chore: Upgrade framework to v1.17.4 (auto) - #174

Merged
hwbrzzl merged 3 commits into
v1.17.xfrom
auto-upgrade/v1.17.4
Nov 12, 2026
Merged

hwbrzzl merged 3 commits into
v1.17.xfrom
auto-upgrade/v1.17.4

Conversation

@goravel-agent

@goravel-agent goravel-agent commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade the framework dependency to v1.17.4.
  • Filesystem feature tests start their MinIO container from an image that is still published, using the credential variables MinIO reads today.

Why

This branch bumps the framework to v1.17.4. With that bump the filesystem suite could no longer start its MinIO container: minio/minio is no longer published on Docker Hub, so the image could not be pulled, and the pre-2021 MINIO_ACCESS_KEY / MINIO_SECRET_KEY variables are ignored by current MinIO releases, so the client could never authenticate even when a container did start. Both failures happen before any assertion runs.

The test now pulls a published rebuild of the last MinIO release and passes the root credentials through the names MinIO reads today, so the minio disk is exercised again in CI. Client credentials, bucket creation and the policy are untouched.

// Before: the image was gone from Docker Hub and its credentials were ignored
docker := testingdocker.NewImageDriver(contractsdocker.Image{
	Repository: "minio/minio",
	Tag:        "latest",
	Cmd:        []string{"server", "/data"},
	Env: []string{
		"MINIO_ACCESS_KEY=" + minioAccessKey,
		"MINIO_SECRET_KEY=" + minioSecretKey,
	},
	ExposedPorts: []string{"9000"},
})

// After: a published image, with the credential variables MinIO reads today
docker := testingdocker.NewImageDriver(contractsdocker.Image{
	Repository: "coollabsio/minio",
	Tag:        "RELEASE.2025-10-15T17-29-55Z",
	Cmd:        []string{"server", "/data"},
	Env: []string{
		"MINIO_ROOT_USER=" + minioAccessKey,
		"MINIO_ROOT_PASSWORD=" + minioSecretKey,
	},
	ExposedPorts: []string{"9000"},
})

@goravel-agent
goravel-agent requested a review from a team as a code owner November 12, 2026 08:16
@hwbrzzl
hwbrzzl merged commit 0e5240e into v1.17.x Nov 12, 2026
6 checks passed
@hwbrzzl
hwbrzzl deleted the auto-upgrade/v1.17.4 branch November 12, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants